diff options
| author | Andrew Clayton <a.clayton@nginx.com> | 2023-03-23 16:44:26 +0000 |
|---|---|---|
| committer | Andrew Clayton <a.clayton@nginx.com> | 2023-03-28 23:15:28 +0100 |
| commit | f20172e5959d2029fdc7f084a332a748563dd50e (patch) | |
| tree | 2ef7f8fd1c80cd15653a6964d0a3a30ab2166fee | |
| parent | 9b848c515ed9b72625c835c2eda1c0278892e97c (diff) | |
| download | unit-f20172e5959d2029fdc7f084a332a748563dd50e.tar.gz unit-f20172e5959d2029fdc7f084a332a748563dd50e.tar.bz2 | |
Change nxt_bool_t from a nxt_uint_t to a uint8_t.
We have a 'bool' type, nxt_bool_t which is defined as a nxt_uint_t, that
is used as local variables, and function return types and arguments.
However in structs we use a uint8_t, due to not wanting to waste memory
in structures, but the use of uint8_t in structs is confusing and
unintuitive.
We could just switch to using the C99 _Bool type, however there are
concerns about this possibly not always being 1-byte on platforms on
which Unit runs and might mess with structure layouts.
(Switching to _Bool as the underlying type is still an eventual goal)
The alternative is to just make our nxt_bool_t be a uint8_t.
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
| -rw-r--r-- | src/nxt_types.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nxt_types.h b/src/nxt_types.h index 03e9c187..235d5733 100644 --- a/src/nxt_types.h +++ b/src/nxt_types.h @@ -31,7 +31,7 @@ typedef uintptr_t nxt_uint_t; #endif -typedef nxt_uint_t nxt_bool_t; +typedef uint8_t nxt_bool_t; /* |