diff options
| author | Gabor Javorszky <g.javorszky@f5.com> | 2024-02-14 18:16:01 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-14 18:16:01 +0000 |
| commit | fbeb2065b180e2376088387ee150d3975dc08cd5 (patch) | |
| tree | 41401338a7c1f484c0609e4dd63779bedf6aae52 /docs | |
| parent | 2b0d93d1a73703ca4c3f1892cfd922b1d2107fb4 (diff) | |
| download | unit-fbeb2065b180e2376088387ee150d3975dc08cd5.tar.gz unit-fbeb2065b180e2376088387ee150d3975dc08cd5.tar.bz2 | |
fix: Take options as well as requestListener (#1091)
* Take options as well as requestListener
Unit-http have not kept up with the signature of nodejs's http package
development. Nodejs allows an optional `options` object to be passed to
the `createServer` function, we didn't. This resulted in function
signature errors when user code that did make use of the options arg
tried to call unit's replaced function.
This change changes the signature to be more in line with how nodejs
does it discarding it and printing a message to stdout.
* Add test file to start node application with options
* Add changes to docs/changes.xml
Closes: https://github.com/nginx/unit/issues/1043
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/changes.xml | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/docs/changes.xml b/docs/changes.xml index 428da0ba..a3549697 100644 --- a/docs/changes.xml +++ b/docs/changes.xml @@ -53,6 +53,12 @@ NGINX Unit updated to 1.32.0. </para> </change> +<change type="bugfix"> +<para> +http.createServer() now accepts "options" argument introduced in Node.js v9.6.0, v8.12.0. +</para> +</change> + <change type="feature"> <para> conditional access logging. |