diff options
author | Alexander Borisov <alexander.borisov@nginx.com> | 2018-11-15 15:21:52 +0300 |
---|---|---|
committer | Alexander Borisov <alexander.borisov@nginx.com> | 2018-11-15 15:21:52 +0300 |
commit | fb18a09cd748ff0107d4e27e514c9f5caf3aa5e6 (patch) | |
tree | dd8738c57c3df3a083500b0e0dee20a334656dfd /src/nodejs/unit-http/unit.cpp | |
parent | 06b404feb17dec9e3a84da31e213f21a0a9b4846 (diff) | |
download | unit-fb18a09cd748ff0107d4e27e514c9f5caf3aa5e6.tar.gz unit-fb18a09cd748ff0107d4e27e514c9f5caf3aa5e6.tar.bz2 |
Node.js: fixed handling of response header fields.
This fixes two issues:
- values for mutiple header fields with the same name
passed as arrays were converted to string;
- the type of field value wasn't preserved as required
by specification.
Diffstat (limited to '')
-rw-r--r-- | src/nodejs/unit-http/unit.cpp | 25 |
1 files changed, 25 insertions, 0 deletions
diff --git a/src/nodejs/unit-http/unit.cpp b/src/nodejs/unit-http/unit.cpp index 788a5cc8..be64a59b 100644 --- a/src/nodejs/unit-http/unit.cpp +++ b/src/nodejs/unit-http/unit.cpp @@ -696,6 +696,7 @@ Unit::response_send_headers(napi_env env, napi_callback_info info) napi_value this_arg, headers, keys, name, value, array_val; napi_value req_num; napi_status status; + napi_valuetype val_type; nxt_unit_field_t *f; nxt_unit_request_info_t *req; napi_value argv[5]; @@ -805,6 +806,18 @@ Unit::response_send_headers(napi_env env, napi_callback_info info) goto failed; } + napi_typeof(env, array_val, &val_type); + if (status != napi_ok) { + goto failed; + } + + if (val_type != napi_string) { + status = napi_coerce_to_string(env, array_val, &array_val); + if (status != napi_ok) { + goto failed; + } + } + status = napi_get_value_string_latin1(env, array_val, ptr, header_len, &value_len); @@ -830,6 +843,18 @@ Unit::response_send_headers(napi_env env, napi_callback_info info) } } else { + napi_typeof(env, value, &val_type); + if (status != napi_ok) { + goto failed; + } + + if (val_type != napi_string) { + status = napi_coerce_to_string(env, value, &value); + if (status != napi_ok) { + goto failed; + } + } + status = napi_get_value_string_latin1(env, value, ptr, header_len, &value_len); if (status != napi_ok) { |