HTTP parser: allowed more characters in header field names.

Previously, all requests that contained in header field names characters other
than alphanumeric, or "-", or "_" were rejected with a 400 "Bad Request" error
response.

Now, the parser allows the same set of characters as specified in RFC 7230,
including: "!", "#", "$", "%", "&", "'", "*", "+", ".", "^", "`", "|", and "~".
Header field names that contain only these characters are considered valid.

Also, there's a new option introduced: "discard_unsafe_fields".  It accepts
boolean value and it is set to "true" by default.

When this option is "true", all header field names that contain characters
in valid range, but other than alphanumeric or "-" are skipped during parsing.
When the option is "false", these header fields aren't skipped.

Requests with non-valid characters in header field names according to
RFC 7230 are rejected regardless of "discard_unsafe_fields" setting.

This closes #422 issue on GitHub.

1 files changed, 5 insertions, 1 deletions

diff --git a/src/nxt_h1proto.c b/src/nxt_h1proto.c
index dc23d7c4..dccbe56c 100644
--- a/src/nxt_h1proto.c
+++ b/src/nxt_h1proto.c
@@ -467,6 +467,7 @@ nxt_h1p_conn_request_init(nxt_task_t *task, void *obj, void *data)
     nxt_int_t                ret;
     nxt_conn_t               *c;
     nxt_h1proto_t            *h1p;
+    nxt_socket_conf_t        *skcf;
     nxt_http_request_t       *r;
     nxt_socket_conf_joint_t  *joint;
 
@@ -503,11 +504,14 @@ nxt_h1p_conn_request_init(nxt_task_t *task, void *obj, void *data)
             joint->count++;
 
             r->conf = joint;
+            skcf = joint->socket_conf;
 
             if (c->local == NULL) {
-                c->local = joint->socket_conf->sockaddr;
+                c->local = skcf->sockaddr;
             }
 
+            h1p->parser.discard_unsafe_fields = skcf->discard_unsafe_fields;
+
             nxt_h1p_conn_request_header_parse(task, c, h1p);
             return;
         }