diff options
| author | Andrew Clayton <andrew@digital-domain.net> | 2022-06-15 16:20:01 +0100 |
|---|---|---|
| committer | Andrew Clayton <andrew@digital-domain.net> | 2022-07-21 00:37:20 +0100 |
| commit | c1cea3c97d5dfc260a54cab67b7dc1637a3deb59 (patch) | |
| tree | dcc699a083e9c8a9e7ed56f5d11d6c1b13943d3c /src/nxt_http_route_addr.c | |
| parent | 02659b1ee3b041d1f4046ac440ea6755455230a1 (diff) | |
| download | unit-c1cea3c97d5dfc260a54cab67b7dc1637a3deb59.tar.gz unit-c1cea3c97d5dfc260a54cab67b7dc1637a3deb59.tar.bz2 | |
Router: avoided undefined behaviour.
In src/nxt_http_route_addr.c::nxt_http_route_addr_pattern_parse() there
was potentially undefined behaviour when shifting a 32 bit value by 32
bits, this could happen if cidr_prefix was 0.
Promote the shiftee to unsigned long long to avoid this issue.
Diffstat (limited to 'src/nxt_http_route_addr.c')
| -rw-r--r-- | src/nxt_http_route_addr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nxt_http_route_addr.c b/src/nxt_http_route_addr.c index 2907a902..985fb737 100644 --- a/src/nxt_http_route_addr.c +++ b/src/nxt_http_route_addr.c @@ -233,7 +233,7 @@ nxt_http_route_addr_pattern_parse(nxt_mp_t *mp, } addr.length = delim - addr.start; - inet->end = htonl(0xFFFFFFFF & (0xFFFFFFFF << (32 - cidr_prefix))); + inet->end = htonl(0xFFFFFFFF & (0xFFFFFFFFULL << (32 - cidr_prefix))); inet->start = nxt_inet_addr(addr.start, addr.length) & inet->end; if (nxt_slow_path(inet->start == INADDR_NONE)) { |