summaryrefslogtreecommitdiffhomepage
path: root/src/nxt_router.c
diff options
context:
space:
mode:
authorhongzhidao <hongzhidao@gmail.com>2020-08-28 00:53:36 -0400
committerhongzhidao <hongzhidao@gmail.com>2020-08-28 00:53:36 -0400
commit806135f1c93c09bb513efc1341d084951b080278 (patch)
treefad5c6e1fbdcc4be78fb289546ebcfdfbb0aec32 /src/nxt_router.c
parentd5e915934066c77a59d211efafca10c117b73d05 (diff)
downloadunit-806135f1c93c09bb513efc1341d084951b080278.tar.gz
unit-806135f1c93c09bb513efc1341d084951b080278.tar.bz2
Router: fixed "pass" to upstreams.
Messed up return values in nxt_upstream_find() caused error in applying any configuration with a valid "pass" value in router configuration pointing to upstream. That wasn't the case in "listeners" objects, where the return value wasn't checked. Also, it caused segfault in cases where the "pass" option was configured with variables and resulting value was pointing to a non-existent upstream. Added missing return checks as well to catch possible memory allocation errors. The bug was introduced in d32bc428f46b. This closes #472 issue on GitHub.
Diffstat (limited to 'src/nxt_router.c')
-rw-r--r--src/nxt_router.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/nxt_router.c b/src/nxt_router.c
index ea14c6fb..b7408c3c 100644
--- a/src/nxt_router.c
+++ b/src/nxt_router.c
@@ -1725,6 +1725,10 @@ nxt_router_conf_create(nxt_task_t *task, nxt_router_temp_conf_t *tmcf,
tmcf->router_conf,
&lscf.application);
}
+
+ if (nxt_slow_path(skcf->action == NULL)) {
+ goto fail;
+ }
}
}