Fixed #define style.

We had a mix of styles for declaring function-like macros:

Style A:
 #define                    \
 foo()                      \
     do {                   \
         ...                \
     } while (0)

Style B:
 #define foo()              \
     do {                   \
         ...                \
     } while (0)

We had a similar number of occurences of each style:

 $ grep -rnI '^\w*(.*\\' | wc -l
 244
 $ grep -rn 'define.*(.*)' | wc -l
 239

(Those regexes aren't perfect, but a very decent approximation.)

Real examples:

 $ find src -type f | xargs sed -n '/^nxt_double_is_zero/,/^$/p'
 nxt_double_is_zero(f)                                                         \
     (fabs(f) <= FLT_EPSILON)

 $ find src -type f | xargs sed -n '/define nxt_http_field_set/,/^$/p'
 #define nxt_http_field_set(_field, _name, _value)                             \
     do {                                                                      \
         (_field)->name_length = nxt_length(_name);                            \
         (_field)->value_length = nxt_length(_value);                          \
         (_field)->name = (u_char *) _name;                                    \
         (_field)->value = (u_char *) _value;                                  \
     } while (0)

I'd like to standardize on a single style for them, and IMO,
having the identifier in the same line as #define is a better
option for the following reasons:

- Programmers are used to `#define foo() ...` (readability).
- One less line of code.
- The program for finding them is really simple (see below).

 function grep_ngx_func()
 {
     if (($# != 1)); then
         >&2 echo "Usage: ${FUNCNAME[0]} <func>";
         return 1;
     fi;

     find src -type f \
     | grep '\.[ch]$' \
     | xargs grep -l "$1" \
     | sort \
     | xargs pcregrep -Mn "(?s)^\$[\w\s*]+?^$1\(.*?^}";

     find src -type f \
     | grep '\.[ch]$' \
     | xargs grep -l "$1" \
     | sort \
     | xargs pcregrep -Mn "(?s)define $1\(.*?^$" \
     | sed -E '1s/^[^:]+:[0-9]+:/&\n\n/';
 }

 $ grep_ngx_func
 Usage: grep_ngx_func <func>

 $ grep_ngx_func nxt_http_field_set
 src/nxt_http.h:98:

 #define nxt_http_field_set(_field, _name, _value)                             \
     do {                                                                      \
         (_field)->name_length = nxt_length(_name);                            \
         (_field)->value_length = nxt_length(_value);                          \
         (_field)->name = (u_char *) _name;                                    \
         (_field)->value = (u_char *) _value;                                  \
     } while (0)

 $ grep_ngx_func nxt_sprintf
 src/nxt_sprintf.c:56:

 u_char * nxt_cdecl
 nxt_sprintf(u_char *buf, u_char *end, const char *fmt, ...)
 {
     u_char   *p;
     va_list  args;

     va_start(args, fmt);
     p = nxt_vsprintf(buf, end, fmt, args);
     va_end(args);

     return p;
 }

................
Scripted change:
................

$ find src -type f \
  | grep '\.[ch]$' \
  | xargs sed -i '/define *\\$/{N;s/ *\\\n/ /;s/        //}'

1 files changed, 11 insertions, 22 deletions

diff --git a/src/nxt_thread.h b/src/nxt_thread.h
index 2ebc331d..53b2d8c0 100644
--- a/src/nxt_thread.h
+++ b/src/nxt_thread.h
@@ -30,19 +30,15 @@
 
 #if (NXT_HAVE_THREAD_STORAGE_CLASS)
 
-#define                                                                       \
-nxt_thread_extern_data(type, tsd)                                             \
+#define nxt_thread_extern_data(type, tsd)                                     \
     NXT_EXPORT extern __thread type  tsd
 
-#define                                                                       \
-nxt_thread_declare_data(type, tsd)                                            \
+#define nxt_thread_declare_data(type, tsd)                                    \
     __thread type  tsd
 
-#define                                                                       \
-nxt_thread_init_data(tsd)
+#define nxt_thread_init_data(tsd)
 
-#define                                                                       \
-nxt_thread_get_data(tsd)                                                      \
+#define nxt_thread_get_data(tsd)                                              \
     &tsd
 
 
@@ -67,18 +63,15 @@ typedef struct {
 } nxt_thread_specific_data_t[1];
 
 
-#define                                                                       \
-nxt_thread_extern_data(type, tsd)                                             \
+#define nxt_thread_extern_data(type, tsd)                                     \
     NXT_EXPORT extern nxt_thread_specific_data_t  tsd
 
-#define                                                                       \
-nxt_thread_declare_data(type, tsd)                                            \
+#define nxt_thread_declare_data(type, tsd)                                    \
     nxt_thread_specific_data_t tsd = { { (nxt_atomic_int_t) -1, sizeof(type) } }
 
 NXT_EXPORT void nxt_thread_init_data(nxt_thread_specific_data_t tsd);
 
-#define                                                                       \
-nxt_thread_get_data(tsd)                                                      \
+#define nxt_thread_get_data(tsd)                                              \
     pthread_getspecific((pthread_key_t) tsd->key)
 
 #endif
@@ -101,8 +94,7 @@ NXT_EXPORT void nxt_thread_cancel(nxt_thread_handle_t handle);
 NXT_EXPORT void nxt_thread_wait(nxt_thread_handle_t handle);
 
 
-#define                                                                       \
-nxt_thread_handle()                                                           \
+#define nxt_thread_handle()                                                   \
     pthread_self()
 
 
@@ -125,18 +117,15 @@ NXT_EXPORT nxt_err_t nxt_thread_cond_wait(nxt_thread_cond_t *cond,
 
 
 #if (NXT_HAVE_PTHREAD_YIELD)
-#define                                                                       \
-nxt_thread_yield()                                                            \
+#define nxt_thread_yield()                                                    \
     pthread_yield()
 
 #elif (NXT_HAVE_PTHREAD_YIELD_NP)
-#define                                                                       \
-nxt_thread_yield()                                                            \
+#define nxt_thread_yield()                                                    \
     pthread_yield_np()
 
 #else
-#define                                                                       \
-nxt_thread_yield()                                                            \
+#define nxt_thread_yield()                                                    \
     nxt_sched_yield()
 
 #endif