diff options
| author | Valentin Bartenev <vbart@nginx.com> | 2019-02-28 20:20:41 +0300 |
|---|---|---|
| committer | Valentin Bartenev <vbart@nginx.com> | 2019-02-28 20:20:41 +0300 |
| commit | a5dd0f8aa9b81921ff28c486a39fd46607dbdbd9 (patch) | |
| tree | b4977f8e3efab694a10be83d1c09c673452d27a4 /src/ruby/nxt_ruby.c | |
| parent | 7ce6f0597543baee4275e8d66567d08f2ddaf48b (diff) | |
| download | unit-a5dd0f8aa9b81921ff28c486a39fd46607dbdbd9.tar.gz unit-a5dd0f8aa9b81921ff28c486a39fd46607dbdbd9.tar.bz2 | |
Made QUERY_STRING mandatory.
According to CGI/1.1 RFC 3875:
The server MUST set this variable; if the Script-URI does not include a
query component, the QUERY_STRING MUST be defined as an empty string ("").
Python's PEP 333(3) allows omitting it in WSGI interface; PHP docs force no
requirements; PSGI and Rack specifications require it even if empty.
When nginx proxies requests over FastCGI, it always provides QUERY_STRING.
and some PHP apps have been observed to fail if it is missing (see issue
#201 on GitHub).
A drawback of this change (besides a small overhead) is that there will be
no easy way to tell a missing query string from an empty one (i.e. requests
with or without the "?" character); yet, it's negligible compared to the
possible benefits of wider application compatibility.
This closes #226 issue on GitHub.
Diffstat (limited to '')
| -rw-r--r-- | src/ruby/nxt_ruby.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/ruby/nxt_ruby.c b/src/ruby/nxt_ruby.c index 17831175..b2398abe 100644 --- a/src/ruby/nxt_ruby.c +++ b/src/ruby/nxt_ruby.c @@ -442,10 +442,8 @@ nxt_ruby_read_request(VALUE hash_env) nxt_ruby_add_sptr(hash_env, NL("REQUEST_URI"), &r->target, r->target_length); nxt_ruby_add_sptr(hash_env, NL("PATH_INFO"), &r->path, r->path_length); - if (r->query.offset) { - nxt_ruby_add_sptr(hash_env, NL("QUERY_STRING"), &r->query, - r->query_length); - } + nxt_ruby_add_sptr(hash_env, NL("QUERY_STRING"), &r->query, + r->query_length); nxt_ruby_add_sptr(hash_env, NL("SERVER_PROTOCOL"), &r->version, r->version_length); nxt_ruby_add_sptr(hash_env, NL("REMOTE_ADDR"), &r->remote, |