diff options
author | Gabor Javorszky <g.javorszky@f5.com> | 2024-02-14 18:16:01 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-14 18:16:01 +0000 |
commit | fbeb2065b180e2376088387ee150d3975dc08cd5 (patch) | |
tree | 41401338a7c1f484c0609e4dd63779bedf6aae52 /test/test_node_application.py | |
parent | 2b0d93d1a73703ca4c3f1892cfd922b1d2107fb4 (diff) | |
download | unit-fbeb2065b180e2376088387ee150d3975dc08cd5.tar.gz unit-fbeb2065b180e2376088387ee150d3975dc08cd5.tar.bz2 |
fix: Take options as well as requestListener (#1091)
* Take options as well as requestListener
Unit-http have not kept up with the signature of nodejs's http package
development. Nodejs allows an optional `options` object to be passed to
the `createServer` function, we didn't. This resulted in function
signature errors when user code that did make use of the options arg
tried to call unit's replaced function.
This change changes the signature to be more in line with how nodejs
does it discarding it and printing a message to stdout.
* Add test file to start node application with options
* Add changes to docs/changes.xml
Closes: https://github.com/nginx/unit/issues/1043
Diffstat (limited to 'test/test_node_application.py')
-rw-r--r-- | test/test_node_application.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/test/test_node_application.py b/test/test_node_application.py index cb775210..88ae3136 100644 --- a/test/test_node_application.py +++ b/test/test_node_application.py @@ -21,6 +21,12 @@ def test_node_application_basic(): assert_basic_application() +def test_node_application_options(wait_for_record): + client.load('options') + + assert_basic_application() + assert wait_for_record(r'constructor was called with unsupported') is not None + def test_node_application_loader_unit_http(): client.load('loader/unit_http') |