summaryrefslogtreecommitdiffhomepage
path: root/test/test_php_application.py
diff options
context:
space:
mode:
authorValentin Bartenev <vbart@nginx.com>2019-07-05 18:42:30 +0300
committerValentin Bartenev <vbart@nginx.com>2019-07-05 18:42:30 +0300
commit924165c90ba51dd4ffea2c45541d46af56352d73 (patch)
tree2e0287393a13e2c0fc162585d73f72eea7fb8332 /test/test_php_application.py
parente1de5bcfabf468b88b42aa27c60a643e97aacc11 (diff)
downloadunit-924165c90ba51dd4ffea2c45541d46af56352d73.tar.gz
unit-924165c90ba51dd4ffea2c45541d46af56352d73.tar.bz2
PHP: improved response status code handling.
There's no reason to parse "http_status_line"; the PHP interpreter already does this. If the line contains a valid status code, it's assigned to "http_response_code". This also fixes invalid status line handling, where the nxt_int_parse() function returned -1; it was cast to unsigned, yielding response code 65535.
Diffstat (limited to '')
-rw-r--r--test/test_php_application.py40
1 files changed, 40 insertions, 0 deletions
diff --git a/test/test_php_application.py b/test/test_php_application.py
index 8032e96e..bf0d3bd1 100644
--- a/test/test_php_application.py
+++ b/test/test_php_application.py
@@ -102,6 +102,46 @@ class TestPHPApplication(TestApplicationPHP):
self.assertEqual(resp['status'], 200, 'status')
self.assertNotEqual(resp['body'], '', 'body not empty')
+ def test_php_application_header_status(self):
+ self.load('header')
+
+ self.assertEqual(
+ self.get(
+ headers={
+ 'Host': 'localhost',
+ 'Connection': 'close',
+ 'X-Header': 'HTTP/1.1 404 Not Found',
+ }
+ )['status'],
+ 404,
+ 'status',
+ )
+
+ self.assertEqual(
+ self.get(
+ headers={
+ 'Host': 'localhost',
+ 'Connection': 'close',
+ 'X-Header': 'http/1.1 404 Not Found',
+ }
+ )['status'],
+ 404,
+ 'status case insensitive',
+ )
+
+ self.assertEqual(
+ self.get(
+ headers={
+ 'Host': 'localhost',
+ 'Connection': 'close',
+ 'X-Header': 'HTTP/ 404 Not Found',
+ }
+ )['status'],
+ 404,
+ 'status version empty',
+ )
+
+
def test_php_application_404(self):
self.load('404')