summaryrefslogtreecommitdiffhomepage
path: root/test
diff options
context:
space:
mode:
authorValentin Bartenev <vbart@nginx.com>2019-02-28 20:20:41 +0300
committerValentin Bartenev <vbart@nginx.com>2019-02-28 20:20:41 +0300
commita5dd0f8aa9b81921ff28c486a39fd46607dbdbd9 (patch)
treeb4977f8e3efab694a10be83d1c09c673452d27a4 /test
parent7ce6f0597543baee4275e8d66567d08f2ddaf48b (diff)
downloadunit-a5dd0f8aa9b81921ff28c486a39fd46607dbdbd9.tar.gz
unit-a5dd0f8aa9b81921ff28c486a39fd46607dbdbd9.tar.bz2
Made QUERY_STRING mandatory.
According to CGI/1.1 RFC 3875: The server MUST set this variable; if the Script-URI does not include a query component, the QUERY_STRING MUST be defined as an empty string (""). Python's PEP 333(3) allows omitting it in WSGI interface; PHP docs force no requirements; PSGI and Rack specifications require it even if empty. When nginx proxies requests over FastCGI, it always provides QUERY_STRING. and some PHP apps have been observed to fail if it is missing (see issue #201 on GitHub). A drawback of this change (besides a small overhead) is that there will be no easy way to tell a missing query string from an empty one (i.e. requests with or without the "?" character); yet, it's negligible compared to the possible benefits of wider application compatibility. This closes #226 issue on GitHub.
Diffstat (limited to 'test')
-rw-r--r--test/test_python_application.py1
1 files changed, 0 insertions, 1 deletions
diff --git a/test/test_python_application.py b/test/test_python_application.py
index da5d3ba2..a8631085 100644
--- a/test/test_python_application.py
+++ b/test/test_python_application.py
@@ -65,7 +65,6 @@ class TestUnitPythonApplication(unit.TestUnitApplicationPython):
self.assertEqual(resp['headers']['Query-String'], '',
'query string empty')
- @unittest.expectedFailure
def test_python_application_query_string_absent(self):
self.load('query_string')