From 8f0dd9478e164121e31bebaf1c10dd6e537d2918 Mon Sep 17 00:00:00 2001
From: Andrew Clayton <a.clayton@nginx.com>
Date: Fri, 28 Oct 2022 00:17:51 +0100
Subject: Fixed main() prototypes in auto tests.

Future releases of GCC are planning to remove[0] default support for
some old features that were removed from C99 but GCC still accepts.

We can test for these changes by using the following -Werror=
directives

  -Werror=implicit-int
  -Werror=implicit-function-declaration
  -Werror=int-conversion
  -Werror=strict-prototypes
  -Werror=old-style-definition

Doing so revealed an issue with the auto/ tests in that the test
programs always define main as

  int main()

rather than

  int main(void)

which results in a bunch of errors like

build/autotest.c:3:23: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    3 |                   int main() {
      |                       ^~~~
build/autotest.c: In function 'main':
build/autotest.c:3:23: error: old-style function definition [-Werror=old-style-definition]

The fix was easy, it only required fixing the main prototype with

  find -type f -exec sed -i 's/int main() {/int main(void) {/g' {} \;

Regardless of these upcoming GCC changes, this is probably a good thing
to do anyway for correctness.

[0]: https://fedoraproject.org/wiki/Changes/PortingToModernC

Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CJXKTLXJUPZ4F2C2VQOTNMEA5JAUPMBD/>
Link: <https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6SGHPHPAXKCVJ6PUZ57WVDQ5TDBVIRMF/>
Reviewed-by: Alejandro Colomar <alx@nginx.com>
Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
---
 auto/unix | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

(limited to 'auto/unix')

diff --git a/auto/unix b/auto/unix
index 45c6a139..1307bdbd 100644
--- a/auto/unix
+++ b/auto/unix
@@ -13,7 +13,7 @@ nxt_feature_libs=
 nxt_feature_test="#include <unistd.h>
                   #include <sys/random.h>
 
-                  int main() {
+                  int main(void) {
                       char  buf[4];
 
                       if (getrandom(buf, 4, 0) < 0) {
@@ -35,7 +35,7 @@ if [ $nxt_found = no ]; then
                       #include <sys/syscall.h>
                       #include <linux/random.h>
 
-                      int main() {
+                      int main(void) {
                           char  buf[4];
 
                           if (syscall(SYS_getrandom, buf, 4, 0) < 0) {
@@ -56,7 +56,7 @@ if [ $nxt_found = no ]; then
     nxt_feature_name=NXT_HAVE_GETENTROPY
     nxt_feature_test="#include <unistd.h>
 
-                      int main() {
+                      int main(void) {
                           char  buf[4];
 
                           if (getentropy(buf, 4) == -1) {
@@ -78,7 +78,7 @@ if [ $nxt_found = no ]; then
     nxt_feature_test="#include <unistd.h>
                       #include <sys/random.h>
 
-                      int main() {
+                      int main(void) {
                           char  buf[4];
 
                           if (getentropy(buf, 4) == -1) {
@@ -99,7 +99,7 @@ nxt_feature_libs=
 nxt_feature_test="#include <stdlib.h>
                   #include <ucontext.h>
 
-                  int main() {
+                  int main(void) {
                       ucontext_t  uc;
 
                       if (getcontext(&uc) == 0) {
@@ -126,7 +126,7 @@ if [ $nxt_found = no ]; then
                       #include <stdlib.h>
                       #include <ucontext.h>
 
-                      int main() {
+                      int main(void) {
                           ucontext_t  uc;
 
                           if (getcontext(&uc) == 0) {
@@ -155,7 +155,7 @@ nxt_feature_libs=
 nxt_feature_test="#include <stdlib.h>
                   #include <dlfcn.h>
 
-                  int main() {
+                  int main(void) {
                       void *h = dlopen(NULL, RTLD_NOW | RTLD_GLOBAL);
                       dlsym(h, \"\");
                       dlclose(h);
@@ -188,7 +188,7 @@ nxt_feature_libs=
 nxt_feature_test="#include <stdlib.h>
                   #include <unistd.h>
 
-                  int main() {
+                  int main(void) {
                       setproctitle(\"%s\", \"title\");
                       return 0;
                   }"
@@ -204,7 +204,7 @@ nxt_feature_libs=
 nxt_feature_test="#include <unistd.h>
                   #include <grp.h>
 
-                  int main() {
+                  int main(void) {
                       getgrouplist(\"root\", 0, NULL, NULL);
                       return 0;
                   }"
-- 
cgit