From bc4a1d86b940ee998d8f9477f32a6452337eb3b3 Mon Sep 17 00:00:00 2001
From: Andrey Zelenkov <zelenkov@nginx.com>
Date: Fri, 26 Apr 2019 17:35:31 +0300
Subject: Tests: TestControl refactored.

---
 test/unit/control.py | 87 +++++++++++++++++++++++++++++-----------------------
 1 file changed, 48 insertions(+), 39 deletions(-)

(limited to 'test/unit/control.py')

diff --git a/test/unit/control.py b/test/unit/control.py
index c4cfc4ce..0899d34f 100644
--- a/test/unit/control.py
+++ b/test/unit/control.py
@@ -2,47 +2,56 @@ import json
 from unit.http import TestHTTP
 
 
+def args_handler(conf_func):
+    def args_wrapper(self, *args):
+        argcount = conf_func.__code__.co_argcount
+        url_default = '/config'
+        conf = None
+
+        if argcount == 2:
+            url = args[0] if len(args) == 1 else url_default
+
+        elif argcount == 3:
+            conf = args[0]
+
+            if isinstance(conf, dict) or isinstance(conf, list):
+                conf = json.dumps(conf)
+
+            url = args[1] if len(args) == 2 else url_default
+
+        url = url if url.startswith('/') else url_default + '/' + url
+        arguments = (self, url) if conf is None else (self, conf, url)
+
+        return json.loads(conf_func(*arguments))
+
+    return args_wrapper
+
+
 class TestControl(TestHTTP):
 
     # TODO socket reuse
     # TODO http client
 
-    def conf(self, conf, path='/config'):
-        if isinstance(conf, dict) or isinstance(conf, list):
-            conf = json.dumps(conf)
-
-        if path[:1] != '/':
-            path = '/config/' + path
-
-        return json.loads(
-            self.put(
-                url=path,
-                body=conf,
-                sock_type='unix',
-                addr=self.testdir + '/control.unit.sock',
-            )['body']
-        )
-
-    def conf_get(self, path='/config'):
-        if path[:1] != '/':
-            path = '/config/' + path
-
-        return json.loads(
-            self.get(
-                url=path,
-                sock_type='unix',
-                addr=self.testdir + '/control.unit.sock',
-            )['body']
-        )
-
-    def conf_delete(self, path='/config'):
-        if path[:1] != '/':
-            path = '/config/' + path
-
-        return json.loads(
-            self.delete(
-                url=path,
-                sock_type='unix',
-                addr=self.testdir + '/control.unit.sock',
-            )['body']
-        )
+    @args_handler
+    def conf(self, conf, url):
+        return self.put(**self._get_args(url, conf))['body']
+
+    @args_handler
+    def conf_get(self, url):
+        return self.get(**self._get_args(url))['body']
+
+    @args_handler
+    def conf_delete(self, url):
+        return self.delete(**self._get_args(url))['body']
+
+    def _get_args(self, url, conf=None):
+        args = {
+            'url': url,
+            'sock_type': 'unix',
+            'addr': self.testdir + '/control.unit.sock',
+        }
+
+        if conf is not None:
+            args['body'] = conf
+
+        return args
-- 
cgit