summaryrefslogtreecommitdiffhomepage
path: root/src/nxt_var.c
diff options
context:
space:
mode:
authorAlejandro Colomar <alx@nginx.com>2022-11-02 21:45:40 +0100
committerAlejandro Colomar <alx@nginx.com>2022-11-04 00:30:50 +0100
commitebf02266a2cd663ad4744d3b8c07e211b8f38da1 (patch)
tree4d55a48c6b5ab9417f259ac04d5ad55018de8036 /src/nxt_var.c
parent1b05161107112f09c15b128090284bb6de5b4f70 (diff)
downloadunit-ebf02266a2cd663ad4744d3b8c07e211b8f38da1.tar.gz
unit-ebf02266a2cd663ad4744d3b8c07e211b8f38da1.tar.bz2
Removed the unsafe nxt_memchr() wrapper for memchr(3).
The casts are unnecessary, since memchr(3)'s argument is 'const void *'. It might have been necessary in the times of K&R, where 'void *' didn't exist. Nowadays, it's unnecessary, and _very_ unsafe, since casts can hide all classes of bugs by silencing most compiler warnings. The changes from nxt_memchr() to memchr(3) were scripted: $ find src/ -type f \ | grep '\.[ch]$' \ | xargs sed -i 's/nxt_memchr/memchr/' Reviewed-by: Andrew Clayton <a.clayton@nginx.com> Signed-off-by: Alejandro Colomar <alx@nginx.com>
Diffstat (limited to 'src/nxt_var.c')
-rw-r--r--src/nxt_var.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nxt_var.c b/src/nxt_var.c
index f55a2d30..15759eb4 100644
--- a/src/nxt_var.c
+++ b/src/nxt_var.c
@@ -456,7 +456,7 @@ nxt_var_next_part(u_char *start, size_t length, nxt_str_t *part,
end = start + length;
- p = nxt_memchr(start, '$', length);
+ p = memchr(start, '$', length);
if (p == start) {
*is_var = 1;